Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: billilge/stream-server/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
feat/#84-member-oauth-profile(코드상 의존은 #88의OAuthClient포트뿐)🎯 해결하려는 문제가 무엇인가요?
OAuthClient의 KConnect(국민대 학생용 OAuth) 구현체를 추가합니다.❓ 왜 해결해야 하나요?
국민대 학생 로그인 수단이 KConnect입니다. 또 KConnect 측에서 API 명세를 공개하지 말아 달라고 요청해서, 주소·경로·응답 필드를 코드에 두지 않아야 합니다(이 저장소는 public).
⭐ 어떻게 해결했나요?
oauth.kconnect.*): 코드에는 범용 "code 교환 + JSON 매핑"만 남았습니다..env.example에는 자리표시자만 있고 실제 값은 팀 내부 문서에 있습니다.KConnectClientConfig의 RestClient 빈)invalid_grant(code 만료·재사용·verifier 불일치) → 401INVALID_AUTHORIZATION_CODEinvalid_client등 그 밖의 4xx →IllegalStateException→ 500 + error 로그(서버 설정 오류라 알아야 함)OAUTH_PROVIDER_UNAVAILABLE🧩 이 PR의 한계 & 트레이드오프
⛓️ 기존 기능에 미치는 영향
infrastructure:client가core:domain:auth에 의존합니다.KCONNECT_*를 Coolify dev/prod에 등록해야 합니다(.env.example참고). 등록하지 않아도 기동은 됩니다.🔀 Edge Case & 실패 시나리오
📋 검토한 대안과 선택 이유
💬 리뷰 포인트