Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: billilge/stream-server/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
feat/#84-member-oauth-profile(#89의Department학부 판별 위에 표시명을 추가)🎯 해결하려는 문제가 무엇인가요?
학부를 응답으로 내려줄 때 enum 이름(
SW/AI)이 그대로 나갑니다.❓ 왜 해결해야 하나요?
화면에는 "소프트웨어학부"·"인공지능학부"로 보여야 합니다. 판별은 소속 문자열의 전공명("소프트웨어전공"·"인공지능전공")으로 하지만, 표시는 학부명으로 합니다.
⭐ 어떻게 해결했나요?
Department에displayName추가AdminFeeSearchResponse)의department를name()대신displayName()으로 변경🧩 이 PR의 한계 & 트레이드오프
없습니다.
⛓️ 기존 기능에 미치는 영향
department값이SW/AI→소프트웨어학부/인공지능학부로 바뀝니다. 운영진 웹이 이 값으로 분기하고 있다면 함께 수정해야 합니다.🔀 Edge Case & 실패 시나리오
department가null입니다.📋 검토한 대안과 선택 이유
💬 리뷰 포인트