-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat/#68] 빌릴게 물품·대여 이력·반납 필요 조회 API 추가 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
946f31b
feat: 물품 카테고리·반납 정책 컬럼과 대여 이력 인덱스 추가
jjunh33 0762211
feat: 물품·대여 이력 조회 서비스와 레포지토리 포트 추가
jjunh33 480c2b3
feat: 물품·대여 이력 레포지토리 구현체 추가
jjunh33 d4bbe1a
feat: 학생 앱 빌릴게 물품·대여 이력 조회 API 추가
jjunh33 6061f0d
refactor: 대여 이력 조회 2건에서 불필요한 readOnly 트랜잭션 제거
jjunh33 99c0673
refactor: 응답을 본뜬 조회 record를 도메인 객체를 담는 RentalRecord로 교체
jjunh33 d57dc7d
refactor: 물품 목록의 첫 페이지·다음 페이지 쿼리를 하나로 합침
jjunh33 6cdf462
refactor: 물품 검색을 LIKE 패턴 조립 대신 LOCATE 쿼리로 변경
jjunh33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
api/app-api/src/main/java/kr/ac/kookmin/stream/api/app/welfare/rental/AppRentalApi.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental; | ||
|
|
||
| import io.swagger.v3.oas.annotations.Operation; | ||
| import io.swagger.v3.oas.annotations.tags.Tag; | ||
| import kr.ac.kookmin.stream.api.app.AppApiUser; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.request.ItemListParams; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.request.RentalHistoryListParams; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.response.ItemListItemResponse; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.response.RentalHistoryListResponse; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.response.ReturnRequiredListResponse; | ||
| import kr.ac.kookmin.stream.api.common.dto.ApiResponse; | ||
| import kr.ac.kookmin.stream.api.common.dto.CursorSliceResponse; | ||
| import kr.ac.kookmin.stream.api.common.openapi.ApiErrorCode; | ||
| import kr.ac.kookmin.stream.common.CommonErrorCode; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.RentalErrorCode; | ||
| import org.springdoc.core.annotations.ParameterObject; | ||
|
|
||
| /** | ||
| * 학생 앱 빌릴게(물품 대여) API의 문서 명세. 구현은 {@link AppRentalController}가 맡는다. | ||
| * <p> | ||
| * 스웨거 문서용 어노테이션만 이쪽에 두고 컨트롤러에는 라우팅과 본문만 남긴다. 경로 매핑과 | ||
| * 파라미터 바인딩(@{@code ModelAttribute} 등)은 구현체에 둔다. | ||
| */ | ||
| @Tag(name = "빌릴게", description = "학생 앱 빌릴게 물품·대여 이력 조회") | ||
| public interface AppRentalApi { | ||
|
|
||
| /** 물품 목록. 이름순 커서 페이지네이션이며 카테고리·검색어로 거른다. */ | ||
| @Operation(summary = "물품 목록 조회", | ||
| description = "물품을 이름순으로 커서 기반 조회한다. category로 분류를, keyword로 이름 검색을 거르고 " | ||
| + "cursor/size로 다음 페이지를 넘긴다. 반납 정책(returnPolicy)은 대여품(RENTAL)에만 내려가고 소모품은 null이다.") | ||
| @ApiErrorCode(type = CommonErrorCode.class, codes = {"INVALID_INPUT"}) | ||
| @ApiErrorCode(type = RentalErrorCode.class, codes = {"ITEM_INVALID_CURSOR"}) | ||
| ApiResponse<CursorSliceResponse<ItemListItemResponse>> getItems(@ParameterObject ItemListParams params); | ||
|
|
||
| /** 내 대여 이력. 최근 신청순이며 상태로 거른다. */ | ||
| @Operation(summary = "내 대여 이력 조회", | ||
| description = "내 대여 이력을 최근 신청순으로 조회한다. status를 생략하면 전체 상태를 조회한다.") | ||
| @ApiErrorCode(type = CommonErrorCode.class, codes = {"INVALID_INPUT"}) | ||
| ApiResponse<RentalHistoryListResponse> getHistories( | ||
| AppApiUser apiUser, | ||
| @ParameterObject RentalHistoryListParams params | ||
| ); | ||
|
|
||
| /** 지금 반납해야 하는 대여와 반납 기한. */ | ||
| @Operation(summary = "반납 필요 대여 조회", | ||
| description = "지금 반납해야 하는 대여(대여 중 상태)와 반납 기한(dueAt)을 조회한다. " | ||
| + "반납 기한은 대여일에 최대 대여 일수를 더한 날의 반납 마감 시각이다. 없으면 빈 배열이다.") | ||
| ApiResponse<ReturnRequiredListResponse> getReturnRequired(AppApiUser apiUser); | ||
| } |
59 changes: 59 additions & 0 deletions
59
...pp-api/src/main/java/kr/ac/kookmin/stream/api/app/welfare/rental/AppRentalController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental; | ||
|
|
||
| import jakarta.validation.Valid; | ||
| import kr.ac.kookmin.stream.api.app.AppApiUser; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.request.ItemListParams; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.request.RentalHistoryListParams; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.response.ItemListItemResponse; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.response.RentalHistoryListResponse; | ||
| import kr.ac.kookmin.stream.api.app.welfare.rental.response.ReturnRequiredListResponse; | ||
| import kr.ac.kookmin.stream.api.common.dto.ApiResponse; | ||
| import kr.ac.kookmin.stream.api.common.dto.CursorSliceResponse; | ||
| import kr.ac.kookmin.stream.common.CursorSliceResult; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.Item; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.service.ItemService; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.service.RentalHistoryService; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.ModelAttribute; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/v1/app/billilge") | ||
| @RequiredArgsConstructor | ||
| public class AppRentalController implements AppRentalApi { | ||
|
|
||
| private final ItemService itemService; | ||
| private final RentalHistoryService rentalHistoryService; | ||
|
|
||
| @Override | ||
| @GetMapping("/items") | ||
| public ApiResponse<CursorSliceResponse<ItemListItemResponse>> getItems( | ||
| @Valid @ModelAttribute ItemListParams params | ||
| ) { | ||
| CursorSliceResult<Item> result = itemService.getItems( | ||
| params.toCategory(), params.toKeyword(), params.toCursor(), params.sizeOrDefault() | ||
| ); | ||
| return ApiResponse.success(CursorSliceResponse.from(result, ItemListItemResponse::from)); | ||
| } | ||
|
|
||
| @Override | ||
| @GetMapping("/histories") | ||
| public ApiResponse<RentalHistoryListResponse> getHistories( | ||
| AppApiUser apiUser, | ||
| @Valid @ModelAttribute RentalHistoryListParams params | ||
| ) { | ||
| return ApiResponse.success(RentalHistoryListResponse.from( | ||
| rentalHistoryService.getHistories(apiUser.userId(), params.toStatus()) | ||
| )); | ||
| } | ||
|
|
||
| @Override | ||
| @GetMapping("/histories/return-required") | ||
| public ApiResponse<ReturnRequiredListResponse> getReturnRequired(AppApiUser apiUser) { | ||
| return ApiResponse.success(ReturnRequiredListResponse.from( | ||
| rentalHistoryService.getReturnRequiredRentals(apiUser.userId()) | ||
| )); | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
...api/src/main/java/kr/ac/kookmin/stream/api/app/welfare/rental/request/ItemListParams.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental.request; | ||
|
|
||
| import jakarta.validation.constraints.Max; | ||
| import jakarta.validation.constraints.Min; | ||
| import kr.ac.kookmin.stream.api.common.CursorCodec; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.ItemCategory; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.ItemCursor; | ||
|
|
||
| public record ItemListParams( | ||
| String category, | ||
|
|
||
| String keyword, | ||
|
|
||
| String cursor, | ||
|
|
||
| @Min(value = 1, message = "조회 개수는 1 이상 100 이하여야 합니다.") | ||
| @Max(value = 100, message = "조회 개수는 1 이상 100 이하여야 합니다.") | ||
| Integer size | ||
| ) { | ||
|
|
||
| private static final int DEFAULT_SIZE = 20; | ||
|
|
||
| public ItemCategory toCategory() { | ||
| return ItemCategory.from(category); | ||
| } | ||
|
|
||
| // 공백뿐인 검색어는 검색하지 않는 것과 같다 | ||
| public String toKeyword() { | ||
| return keyword == null || keyword.isBlank() ? null : keyword.strip(); | ||
| } | ||
|
|
||
| public ItemCursor toCursor() { | ||
| return cursor == null ? null : ItemCursor.from(CursorCodec.decode(cursor)); | ||
| } | ||
|
|
||
| public int sizeOrDefault() { | ||
| return size == null ? DEFAULT_SIZE : size; | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
...ain/java/kr/ac/kookmin/stream/api/app/welfare/rental/request/RentalHistoryListParams.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental.request; | ||
|
|
||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.RentalStatus; | ||
|
|
||
| public record RentalHistoryListParams(String status) { | ||
|
|
||
| public RentalStatus toStatus() { | ||
| return RentalStatus.from(status); | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
...-api/src/main/java/kr/ac/kookmin/stream/api/app/welfare/rental/response/ItemImageUrl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental.response; | ||
|
|
||
| import lombok.AccessLevel; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| /** | ||
| * 물품 이미지 파일 키를 공개 URL로 바꾸는 지점. | ||
| * <p> | ||
| * 파일 키 → 공개 URL 조립이 아직 없어 현재는 항상 null이다. 조립이 생기면 이 메서드만 채우면 된다. | ||
| */ | ||
| @NoArgsConstructor(access = AccessLevel.PRIVATE) | ||
| final class ItemImageUrl { | ||
|
|
||
| static String from(String imageKey) { | ||
| return null; | ||
| } | ||
| } | ||
43 changes: 43 additions & 0 deletions
43
.../main/java/kr/ac/kookmin/stream/api/app/welfare/rental/response/ItemListItemResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental.response; | ||
|
|
||
| import java.time.format.DateTimeFormatter; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.Item; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.ItemCategory; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.ItemType; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.ReturnPolicy; | ||
|
|
||
| public record ItemListItemResponse( | ||
| Long itemId, | ||
| String name, | ||
| ItemCategory category, | ||
| ItemType type, | ||
| int count, | ||
| String imageUrl, | ||
| ReturnPolicyResponse returnPolicy | ||
| ) { | ||
|
|
||
| public static ItemListItemResponse from(Item item) { | ||
| ReturnPolicy returnPolicy = item.getReturnPolicy(); | ||
| return new ItemListItemResponse( | ||
| item.getId(), | ||
| item.getName(), | ||
| item.getCategory(), | ||
| item.getType(), | ||
| item.getCount(), | ||
| ItemImageUrl.from(item.getImageKey()), | ||
| returnPolicy == null ? null : ReturnPolicyResponse.from(returnPolicy) | ||
| ); | ||
| } | ||
|
|
||
| public record ReturnPolicyResponse(int maxRentalDays, String returnDeadline) { | ||
|
|
||
| private static final DateTimeFormatter DEADLINE_FORMAT = DateTimeFormatter.ofPattern("HH:mm"); | ||
|
|
||
| public static ReturnPolicyResponse from(ReturnPolicy returnPolicy) { | ||
| return new ReturnPolicyResponse( | ||
| returnPolicy.maxRentalDays(), | ||
| returnPolicy.returnDeadline().format(DEADLINE_FORMAT) | ||
| ); | ||
| } | ||
| } | ||
| } |
36 changes: 36 additions & 0 deletions
36
.../java/kr/ac/kookmin/stream/api/app/welfare/rental/response/RentalHistoryListResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental.response; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.RentalHistory; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.RentalRecord; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.RentalStatus; | ||
|
|
||
| public record RentalHistoryListResponse(List<History> histories) { | ||
|
|
||
| public static RentalHistoryListResponse from(List<RentalRecord> records) { | ||
| return new RentalHistoryListResponse(records.stream().map(History::from).toList()); | ||
| } | ||
|
|
||
| public record History( | ||
| Long rentalHistoryId, | ||
| String itemName, | ||
| String itemImageUrl, | ||
| LocalDateTime rentAt, | ||
| LocalDateTime returnedAt, | ||
| RentalStatus status | ||
| ) { | ||
|
|
||
| public static History from(RentalRecord record) { | ||
| RentalHistory history = record.history(); | ||
| return new History( | ||
| history.getId(), | ||
| record.itemName(), | ||
| ItemImageUrl.from(record.itemImageKey()), | ||
| history.getRentAt(), | ||
| history.getReturnedAt(), | ||
| history.getRentalStatus() | ||
| ); | ||
| } | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
...java/kr/ac/kookmin/stream/api/app/welfare/rental/response/ReturnRequiredListResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package kr.ac.kookmin.stream.api.app.welfare.rental.response; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
| import kr.ac.kookmin.stream.welfare.domain.rental.domain.RentalRecord; | ||
|
|
||
| public record ReturnRequiredListResponse(List<Rental> rentalHistories) { | ||
|
|
||
| public static ReturnRequiredListResponse from(List<RentalRecord> records) { | ||
| return new ReturnRequiredListResponse(records.stream().map(Rental::from).toList()); | ||
| } | ||
|
|
||
| public record Rental( | ||
| Long rentalHistoryId, | ||
| String itemName, | ||
| String itemImageUrl, | ||
| LocalDateTime dueAt | ||
| ) { | ||
|
|
||
| public static Rental from(RentalRecord record) { | ||
| return new Rental( | ||
| record.history().getId(), | ||
| record.itemName(), | ||
| ItemImageUrl.from(record.itemImageKey()), | ||
| record.dueAt() | ||
| ); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
...welfare/src/main/java/kr/ac/kookmin/stream/welfare/domain/rental/domain/ItemCategory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package kr.ac.kookmin.stream.welfare.domain.rental.domain; | ||
|
|
||
| import kr.ac.kookmin.stream.common.BusinessException; | ||
| import kr.ac.kookmin.stream.common.CommonErrorCode; | ||
|
|
||
| public enum ItemCategory { | ||
| ELECTRONICS, | ||
| DAILY_SUPPLIES, | ||
| MEDICINE, | ||
| HYGIENE; | ||
|
|
||
| public static ItemCategory from(String value) { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| try { | ||
| return ItemCategory.valueOf(value); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new BusinessException(CommonErrorCode.INVALID_INPUT); | ||
| } | ||
| } | ||
| } |
34 changes: 34 additions & 0 deletions
34
...n/welfare/src/main/java/kr/ac/kookmin/stream/welfare/domain/rental/domain/ItemCursor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package kr.ac.kookmin.stream.welfare.domain.rental.domain; | ||
|
|
||
| import kr.ac.kookmin.stream.common.BusinessException; | ||
| import kr.ac.kookmin.stream.common.Cursor; | ||
|
|
||
| /** | ||
| * 물품 목록의 keyset 커서. 정렬 기준(이름 오름차순 + itemId 오름차순)과 짝을 이룬다. | ||
| */ | ||
| public record ItemCursor(String name, Long id) implements Cursor { | ||
|
|
||
| private static final char JOIN = '|'; | ||
|
|
||
| public static ItemCursor of(Item item) { | ||
| return new ItemCursor(item.getName(), item.getId()); | ||
| } | ||
|
|
||
| // 이름에 구분자가 들어 있어도 되도록 id가 오는 마지막 구분자를 기준으로 나눈다(id는 숫자라 구분자를 포함하지 않는다) | ||
| public static ItemCursor from(String raw) { | ||
| int separator = raw.lastIndexOf(JOIN); | ||
| if (separator < 0) { | ||
| throw new BusinessException(RentalErrorCode.ITEM_INVALID_CURSOR); | ||
| } | ||
| try { | ||
| return new ItemCursor(raw.substring(0, separator), Long.valueOf(raw.substring(separator + 1))); | ||
| } catch (NumberFormatException e) { | ||
| throw new BusinessException(RentalErrorCode.ITEM_INVALID_CURSOR); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String format() { | ||
| return name + JOIN + id; | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
...fare/src/main/java/kr/ac/kookmin/stream/welfare/domain/rental/domain/RentalErrorCode.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package kr.ac.kookmin.stream.welfare.domain.rental.domain; | ||
|
|
||
| import kr.ac.kookmin.stream.common.ErrorCode; | ||
| import kr.ac.kookmin.stream.common.ErrorStatus; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Getter; | ||
| import lombok.experimental.Accessors; | ||
|
|
||
| @Getter | ||
| @Accessors(fluent = true) | ||
| @AllArgsConstructor | ||
| public enum RentalErrorCode implements ErrorCode { | ||
|
|
||
| ITEM_INVALID_CURSOR(ErrorStatus.BAD_REQUEST, "유효하지 않은 커서입니다."); | ||
|
|
||
| private final int status; | ||
| private final String message; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ItemImageUrl말고 ImageUrl이나 FileUrl같이 공통으로 쓸 수 있는 객체를 하나 만들어서 합치는 건 어떨까요? 이제 실제 저장소인 r2를 연동했으니까 새로 이슈 파서 key와 url을 결합하는 걸 작업해보시면 좋을듯 합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공통 객체를 만들어서 합치는 의견에 동의합니다. 이후에 별도 이슈로 분리해서 처리하겠습니다!