You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice, this is looking good. I like it that we no longer need Ruby!
A few remarks before we can merge this pull request:
You are using different coding setting. Please use these settings, as many of the proposed changes are just different indentations.
Could we also launch a browser and run the Jasmine tests? This would be super useful during development as we can use the browser to inspect things
Is there a way to exclude the change in the markdown, so we don't have to pollute our history with it, or is that just how it will work with git?
Would this approach also work with validating against the DOM? For example, navigator.js has a test that verifies that the DebugConsole gets wider if the current state is very wide. Would such test fail or succeed?
We can discuss/sort these things out in person/through skype if needed.
Again, really happy that we won't need to use Ruby in this solution and we can stick to just front-end tooling!
Nice, this is looking good. I like it that we no longer need Ruby!
A few remarks before we can merge this pull request:
You are using different coding setting. Please use these settings, as many of the proposed changes are just different indentations.
Could we also launch a browser and run the Jasmine tests? This would be super useful during development as we can use the browser to inspect things
Is there a way to exclude the change in the markdown, so we don't have to pollute our history with it, or is that just how it will work with git?
Would this approach also work with validating against the DOM? For example, navigator.js has a test that verifies that the DebugConsole gets wider if the current state is very wide. Would such test fail or succeed?
We can discuss/sort these things out in person/through skype if needed.
Again, really happy that we won't need to use Ruby in this solution and we can stick to just front-end tooling!
—
Reply to this email directly or view it on GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of Ruby magic and use the power of Grunt & PhantomJS!
grunt-contrib-jasmine