feat(grpo): add DPPO and typed async rollout providers - #1
Open
luke-lombardi wants to merge 2 commits into
Open
luke-lombardi wants to merge 2 commits into
luke-lombardi wants to merge 2 commits into
Conversation
Signed-off-by: Luke Lombardi <33990301+luke-lombardi@users.noreply.github.com>
Signed-off-by: Luke Lombardi <33990301+luke-lombardi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add DPPO and a typed extension point for complete asynchronous tool rollouts. External providers own generation, terminal verification, group admission, and reward shaping; NeMo owns replay, bounded concurrency, policy lag, and training.
loss_fn.dppo_epsilonenables the binary-TV DPPO mask, using actual behavior logprobs and the full assistant-token denominator.RolloutProvider.generate_groups(RolloutRequest)returns completeRolloutGroupResultobjects. Rejected groups request fresh draws; missing, duplicated, malformed, or failed streams fail explicitly.The companion models harness implements the paper workflow through this provider. NeMo has no paper-specific configuration or task/reward logic.
Issues
None.
Usage
See the GRPO guide for DPPO and the provider contract. Configure an external provider with
grpo.async_grpo.rollout_provider: {class_path, kwargs}. The default remains the built-in rollout pipeline, prompt-content grouping, and existing loss.Before this PR is ready for review
Validation
These checks do not establish live distributed SGLang decoding/refits, CP=2 backward passes, or long-context GPU memory fit. The companion harness retains the GPU smoke target for that validation.