#6617 - Remove the impairments before update column - #6620
Merged
sh16011993 merged 3 commits intoSep 17, 2026
Merged
sh16011993 merged 3 commits into
sh16011993 merged 3 commits into
Conversation
sh16011993
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Dropping the only rollback backup prevents the preceding migration from restoring original impairment arrays.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes the temporary disability impairment backup column and adds a TypeORM migration with rollback schema support.
Changes:
- Drops
impairments_before_update. - Recreates the column during rollback.
- Registers the migration.
File summaries
| File | Description |
|---|---|
Delete-impairments-before-update.sql |
Drops the backup column. |
Rollback-delete-impairments-before-update.sql |
Recreates the column and comment. |
1789675751784-DeleteImpairmentsBeforeUpdateCol.ts |
Executes the migration and rollback SQL. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This reverts commit 803dcb3.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
weskubo-cgi
approved these changes
Sep 17, 2026
weskubo-cgi
left a comment
weskubo-cgi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking care of this.
sh16011993
deleted the
feature/#6617-remove-student-disability-profile-impairments-before-update-column
branch
September 17, 2026 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of the PR, the following was completed:
impairments_before_updatewas removed from thestudent_disability_profile_disabilitiestable.