#6516 - Remove offering column added for rollback purpose - #6619
Merged
sh16011993 merged 5 commits intoSep 17, 2026
Merged
sh16011993 merged 5 commits into
sh16011993 merged 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The no-op down migration breaks rollback of the preceding migration, which still references these columns.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a migration to remove rollback-only columns from offering tables.
Changes:
- Drops
study_breaks_before_updatefrom both current and history tables. - Registers the migration with TypeORM.
File summaries
| File | Description |
|---|---|
Delete-study-breaks-before-update.sql |
Removes both columns. |
DeleteStudyBreaksBeforeUpdateCol.ts |
Executes the migration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+14
to
+16
| public async down(): Promise<void> { | ||
| // No down migration needed here. | ||
| } |
This reverts commit ebe0c68.
Backend Unit Tests Coverage Report
|
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
weskubo-cgi
approved these changes
Sep 17, 2026
weskubo-cgi
left a comment
weskubo-cgi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for taking care of this.
sh16011993
deleted the
feature/#6516-remove-offering-column-added-for-rollback-purpose
branch
September 17, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following was completed:
study_breaks_before_updatewas removed from theeducation_programs_offeringsand theeducation_programs_offerings_historytable.