Skip to content

#6415 - Remove student current year income appeal for dependant students - #6615

Merged
weskubo-cgi merged 1 commit into
mainfrom
feature/#6415-student-income-appeal-dependant
Sep 18, 2026
Merged

weskubo-cgi merged 1 commit into
mainfrom
feature/#6415-student-income-appeal-dependant

Conversation

@weskubo-cgi

@weskubo-cgi weskubo-cgi commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Removed student current year income appeal for dependant students.
  • Added supporting E2E tests.
  • Created prod query to be executed with the release.

Screenshots

Independant student

FT Application

image

Application appeals

image

Dependant student

FT Application

image

Application appeals

image

Prod query

-- Find all Pending Student Current Year Income Appeals for dependant students
select applications.application_number, applications.data from sims.form_submissions form_submissions
	inner join sims.applications applications on form_submissions.application_id = applications.id
	inner join sims.form_submission_items form_submission_items on form_submissions.id = form_submission_items.form_submission_id
	inner join sims.dynamic_form_configurations dynamic_form_configurations on form_submission_items.dynamic_form_configuration_id = dynamic_form_configurations.id
  	where form_submissions.submission_status = 'Pending' and dynamic_form_configurations.form_definition_name = 'studentcurrentyearincomeappeal'
  	and applications.data ->> 'dependantstatus' = 'dependant'

E2E tests

E2E Test Workflow fulltime-assessment-2026-2027-appeal-eligibility-student-current-year-income.

image

@weskubo-cgi weskubo-cgi self-assigned this Sep 16, 2026
Copilot AI lite review requested due to automatic review settings September 16, 2026 22:01
@weskubo-cgi
weskubo-cgi marked this pull request as draft September 16, 2026 22:01
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.3% ( 5036 / 24804 )
Methods: 10.02% ( 301 / 3004 )
Lines: 24.57% ( 4254 / 17311 )
Branches: 10.72% ( 481 / 4489 )

@github-actions

Copy link
Copy Markdown

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 48.58% ( 2982 / 6138 )
Methods: 38.57% ( 312 / 809 )
Lines: 55.35% ( 2250 / 4065 )
Branches: 33.23% ( 420 / 1264 )

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow eligibility change is narrowly scoped, aligns with the stated intent, and is covered by a new E2E test validating both dependant and independant scenarios.

Pull request overview

This PR updates the 2026–2027 full-time assessment workflow to make the Student Current Year Income appeal ineligible for dependant students, and adds an E2E workflow test to validate eligibility behavior for dependant vs. independant students.

Changes:

  • Updated the 2026–2027 full-time assessment BPMN to set isEligibleForStudentCurrentYearIncomeAppeal based on studentDataDependantstatus.
  • Added a new E2E workflow spec to assert eligibility is false for dependant and true for independant students.
  • Updated the workspace spellcheck word list to include “Selfemployment”.
File summaries
File Description
sources/packages/backend/workflow/test/2026-2027/fulltime-assessment/appeals/eligibility/fulltime-assessment-appeal-eligibility-student-current-year-income.e2e-spec.ts New E2E workflow test verifying dependant vs. independant eligibility for the student current year income appeal.
sources/packages/backend/workflow/src/workflow-definitions/fulltime-assessment-2026-2027.bpmn Changes eligibility mapping so the student current year income appeal is only eligible when studentDataDependantstatus is independant.
sims.code-workspace Adds “Selfemployment” to cSpell words to avoid false-positive spellcheck flags in the repo.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 81.22% ( 10002 / 12315 )
Methods: 81.22% ( 1306 / 1608 )
Lines: 84.58% ( 7455 / 8814 )
Branches: 65.56% ( 1241 / 1893 )

@github-actions

Copy link
Copy Markdown

E2E SIMS API Coverage Report

Totals Coverage
Statements: 70.86% ( 15365 / 21684 )
Methods: 68.62% ( 1828 / 2664 )
Lines: 73.81% ( 10883 / 14745 )
Branches: 62.08% ( 2654 / 4275 )

@weskubo-cgi
weskubo-cgi marked this pull request as ready for review September 17, 2026 01:03

@andrewsignori-aot andrewsignori-aot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

@weskubo-cgi
weskubo-cgi added this pull request to the merge queue Sep 18, 2026
Merged via the queue into main with commit 864c90f Sep 18, 2026
23 checks passed
@weskubo-cgi
weskubo-cgi deleted the feature/#6415-student-income-appeal-dependant branch September 18, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants