This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Define ending position column #130
Description
There is an inconsistency in java&python drivers. EndPosition.End.Col for java driver returns the position of next character and python driver returns the position of the last character. For example for code print node will have EndPosition.End.Col = 6 for java and EndPosition.End.Col = 5 for python.
Currently, it isn't defined what driver should return, so it depends on native AST.
Position should be defined and later fixed in drivers accordingly.
Activity
bzz commentedon Jun 26, 2018
\cc @dennwc @juanjux what do you guys think?
dennwc commentedon Jun 26, 2018
It should be fixed as a part of v2 release. We are almost there.
bzz commentedon Jun 26, 2018
We are experiencing this with Golang driver as well in gitbase-playground.
🤞 Waiting for v2 😄
dennwc commentedon Jun 26, 2018
Aware of problems with Go drivers, and it's fixed upstream as well :) Tested with bblfsh/uast-viewer#19