sonic: add sonic-vm lab builder support, SonicValidator, and sonic_ebgp lab - #233
Merged
Merged
Conversation
…gp lab Add a SONiC (containerlab sonic-vm) vendor profile to lab_builder: eth1->Ethernet0 port mapping with a stride of 4, BGP health and validate checks, and packaging of config_db.json and frr.conf under sonic_configs/<node>/. build-sonic-image.sh builds the vrnetlab image from the public SONiC VS build and caches it in S3; it patches the wrapper's startup-config restore from "config replace", which stalls on 202605 and leaves bgpd on the default ASN, to "config reload" followed by a bgp restart. Replace the SonicValidator stub. Main RIB validation reuses the FRR validator with a parser for FRR 8+ per-VRF route JSON; interface validation and runtime data come from SONiC "show interfaces status". Add sonic_ebgp, a two-node eBGP lab on SONiC 202605. Interface properties are sickbayed on Batfish's missing SONiC port bandwidth (#232); BGP RIB validation is not implemented. sonic_bgp_lab lacks the new validator inputs, so its interface and RIB tests no longer run. ---- Prompt: ``` Can we add support for SONiC routers to lab validation? ``` Follow-ups: the project is not migration-only, so new code is fine; use a current SONiC image (202605) rather than 202411; send one PR with the infra, validator fixes, and first lab.
dhalperi
enabled auto-merge (squash)
September 23, 2026 15:39
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 83.99% 83.58% -0.42%
==========================================
Files 94 96 +2
Lines 4618 4703 +85
==========================================
+ Hits 3879 3931 +52
- Misses 739 772 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a SONiC (containerlab sonic-vm) vendor profile to lab_builder:
eth1->Ethernet0 port mapping with a stride of 4, BGP health and
validate checks, and packaging of config_db.json and frr.conf under
sonic_configs//. build-sonic-image.sh builds the vrnetlab image
from the public SONiC VS build and caches it in S3; it patches the
wrapper's startup-config restore from "config replace", which stalls on
202605 and leaves bgpd on the default ASN, to "config reload" followed
by a bgp restart.
Replace the SonicValidator stub. Main RIB validation reuses the FRR
validator with a parser for FRR 8+ per-VRF route JSON; interface
validation and runtime data come from SONiC "show interfaces status".
Add sonic_ebgp, a two-node eBGP lab on SONiC 202605. Interface
properties are sickbayed on Batfish's missing SONiC port bandwidth
(#232); BGP RIB validation is not implemented.
sonic_bgp_lab lacks the new validator inputs, so its interface and RIB
tests no longer run.
Prompt:
Follow-ups: the project is not migration-only, so new code is fine; use
a current SONiC image (202605) rather than 202411; send one PR with the
infra, validator fixes, and first lab.