Skip to content

docs(base-account): use HTTPS for Coinbase/Base links in basenames FAQ - #1911

Open
xam-dev-ux wants to merge 1 commit into
base:masterfrom
xam-dev-ux:fix/basenames-faq-https-links
Open

docs(base-account): use HTTPS for Coinbase/Base links in basenames FAQ#1911
xam-dev-ux wants to merge 1 commit into
base:masterfrom
xam-dev-ux:fix/basenames-faq-https-links

Conversation

@xam-dev-ux

Copy link
Copy Markdown

What changed? Why?

The Basenames FAQ links to coinbase.com, basename.app and base.org using http://. All three are Coinbase/Base's own properties and serve over HTTPS.

Closes #1908.

Notes to reviewers

Only the link scheme changed, no wording touched.

How has it been tested?

Verified all three destinations resolve over HTTPS before making the change.

coinbase.com, basename.app and base.org all serve over HTTPS; the
FAQ still linked to the HTTP versions.

Closes base#1908
@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(base-account): HTTP links to Coinbase/Base properties in basenames FAQ

2 participants