Skip to content

Only checks first glob #3

Open
Open

Description

@bartvanderwal

Strange, I thought I tested it, but my plugin currently seems to only check for files in the first glob!

Example

For instance
checkVSIncludes(['/Content/**/*.less', '/Content/*.css']);

returns:
There is 1 of the total 467 checked files NOT included in './MyProject.Web.csproj' ..
./Content/somefile.css
...`

While the same check but specified in another order
checkVSIncludes(['/Content/*.css', '/Content/**/*.less',]); ...

returns:
All 17 checked files are included in './MyProject.Web.csproj'.

This is a bug since both should obviously return the same result:
There is 1 of the total 484 (=467+17) checked files NOT included...

I'll fix it.

Workaround

As a workaround until then you can use multiple calls with a single glob. So for the above example something like:

    checkVSIncludes(['/Content/**/*.less']);
    checkVSIncludes(['/Content/*.css']);

The numbering in the results seems a bit off, but at least any files missing in ANY of the globs are listed.

Activity

  1. TuononenP commented on Nov 13, 2017

    @TuononenP

    Is this fixed yet?

  2. TuononenP commented on Nov 13, 2017

    @TuononenP

    I can confirm this is fixed. I had two files in one folder and 4 in another and the output said "All 6 checked files are included..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions