Repository navigation
fix(WL-566): vocal guidance controller - #29
Merged
Merged
Conversation
DanielAraldi
enabled auto-merge (squash)
October 5, 2026 12:58
nayaradias
disabled auto-merge
October 5, 2026 14:33
Contributor
|
🎉 This PR is included in version 3.8.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The
vocal()method is now a deterministic on/off toggle on both iOS and Android:isEnabledisfalse, callingvocal()enables the vocal guidance and setsisEnabledtotrue.isEnabledistrue, callingvocal()disables the vocal guidance and setsisEnabledtofalse.The
onVocalevent always reflects the real state applied to the Aziface SDK.✅ Checklist
Mark the items that have been completed in this PR:
📱 React Native
--
🤖 Android
vocalGuidanceModeenum toOFF. It never updatedConfig.currentCustomizationor calledsetCustomization, so the FaceTec SDK kept vocal guidance on whileisEnabledwasfalse.OFF → MINIMAL → FULLcycle:setUpVocalGuidancePlayersforcedMINIMAL, andsetVocalGuidanceModethen advanced it toFULL. If the on/off sound was still playing, the mode was set toOFFwhileisEnabledstayedtrue.vocal()while a session was running (IsRunning) set the mode toOFFbut leftisEnabledunchanged.🍎 iOS
vocalGuidanceModeenum toOFF. It never updatedConfig.currentCustomizationor calledsetCustomization, so the FaceTec SDK kept vocal guidance on whileisEnabledwasfalse.OFF → MINIMAL → FULLcycle:setUpVocalGuidancePlayersforcedMINIMAL, andsetVocalGuidanceModethen advanced it toFULL. If the on/off sound was still playing, the mode was set toOFFwhileisEnabledstayedtrue.vocal()while a session was running (IsRunning) set the mode toOFFbut leftisEnabledunchanged.vocal()ran on the TurboModule background queue but accessed UIKit and the Aziface SDK.getCurrentViewController()was force-unwrapped, which could crash when no view controller was found.Vocal(controller:)instance was created but never used. Debugprintstatements were left in the code.Theme.setAppTheme(called on everyinitialize,setThemeandresetTheme) rebuilt the customization without the vocal guidance settings. Vocal guidance was silently lost whileisEnabledstayedtrue.🧪 Testing Notes
Briefly describe how this PR was tested.
Include steps to reproduce or test manually if necessary.
🔗 Related Issues / Tickets
Link any related Jira tickets, GitHub issues, or Trello cards:
--
📸 Evidence (Optional)
Attach any visual evidence of the changes (e.g., screenshots, GIFs, videos, or external links):
--
Add any relevant information that may help reviewers understand the changes faster (e.g., known issues, areas of concern, dependencies, or implementation decisions).
--