Conversation
On Windows the "\" separator in an AppSpec files.source or hooks.location was treated as a filesystem root, so PathBuf::join discarded the archive directory and resolved the path to the drive root. Strip every leading separator via paths::APPSPEC_PATH_SEPARATORS (['/', '\\'] on Windows, ['/'] on Unix) so such paths always resolve inside the deployment archive. Bump agent version to 2.0.1
gmiliaras
marked this pull request as ready for review
September 9, 2026 07:59
filipdanic
approved these changes
Sep 9, 2026
nathan-inge
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
On Windows, a leading
\in an AppSpecfiles.sourceorhooks.locationwas treated as a filesystem root, soPathBuf::joindiscarded the archive directory and resolved the path against the drive root (C:\), failing deployments. Strip all leading separators (/and, on Windows,\) so these paths always resolve inside the deployment archive.Note: on Unix, a source like
//apppreviously escaped to the filesystem root; it now resolves inside the archive.Bumps the agent version to 2.0.1.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.