Skip to content

feat(e2e): enable windows tests - #2416

Merged
tejaskash merged 1 commit into
aws:refactorfrom
Hweinstock:fix/e2e-enable-tests
Sep 28, 2026
Merged

tejaskash merged 1 commit into
aws:refactorfrom
Hweinstock:fix/e2e-enable-tests

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

Windows tests are not running on the e2e branch since the fetch secrets action was not windows compatible.

This has been fixed in aws/agentcore-devx-devtools@75989f6.

Solution

  • bump the fetch action version.
  • active the windows tests.

@github-actions github-actions Bot added the size/xs PR size: XS label Sep 25, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 25, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Changes requested

Nice to see Windows finally coming online. One issue that will bite as soon as this runs:

fetch-secrets SHA was only bumped in one of the two call sites

In .github/workflows/e2e-test.yml, only the authorize job's Fetch secrets from Secrets Manager step (line ~46) was bumped to 75989f65f7f193deaf83c237c36572d1a8f800b2. The second invocation in the e2e job — Fetch E2E role from Secrets Manager at line ~104 — is still pinned to the old 31aa3b031a86664e29861d68956e44b07cf21a74:

- name: Fetch E2E role from Secrets Manager
  uses: aws/agentcore-devx-devtools/.github/actions/fetch-secrets@31aa3b031a86664e29861d68956e44b07cf21a74

That old SHA is the bash-based version — it's the exact one the removed TODO comment called out as not Windows-compatible. The new SHA (aws/agentcore-devx-devtools#5, "swap fetch secret action to use node instead of bash") is what made it Windows-safe. Since the e2e job runs on the matrix including Windows, this step will hit bash on the Windows runner and fail (or at best be flaky, depending on whether Git Bash is on PATH in the image:windows-1.0 runner).

Please bump line 104 to @75989f65f7f193deaf83c237c36572d1a8f800b2 as well (and, while you're in there, the check-authorized-user@31aa3b03... reference on line 51 is fine since authorize runs on ubuntu-latest, but consider keeping all pins in this workflow at the same repo commit for hygiene).

Nit / optional

None of the E2E tests themselves appear to be gated off on Windows, so if any of them shell out to POSIX-only tools or hard-code path separators, expect a wave of new failures on first run. Not a blocker for this PR, just a heads-up — worth watching the first Windows run closely.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 25, 2026
@codecov-commenter

codecov-commenter commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (f035e3f) to head (daf657c).
⚠️ Report is 3 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2416   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
=========================================
  Files           612      612           
  Lines         41019    41019           
=========================================
  Hits          39893    39893           
  Misses         1126     1126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Sep 25, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 25, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 25, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review September 28, 2026 14:08
@tejaskash
tejaskash merged commit 52f9990 into aws:refactor Sep 28, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants