Non-validator: Store blocks from many leaders - #604
Merged
Merged
Conversation
samliok
changed the title
yacovm
reviewed
Sep 21, 2026
| n.sequenceReplicator.ReceivedFutureFinalization(finalization, n.nextSeqToCommit()) | ||
| return nil | ||
| for _, block := range blocks { | ||
| if block.BlockHeader().Digest == bh.Digest { |
Collaborator
There was a problem hiding this comment.
if it's not equal shouldn't we delete the block from memory?
Collaborator
Author
There was a problem hiding this comment.
maybe the finalization we received is for a telock, but the blocks we have in memory are for the next epoch.
yacovm
approved these changes
Sep 25, 2026
| tc := newSeededChain(t, testNodes, 2) | ||
| b3 := tc.appendBlock() | ||
| junk := testutil.NewTestBlock(common.ProtocolMetadata{ | ||
| Round: b3.Metadata.Round + 1, |
Collaborator
There was a problem hiding this comment.
The junk block should be from the same leader no? so it should be b3.Metadata.Round + len(testNodes) no?
Collaborator
|
small nit, otherwise LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversaries can send us many blocks for different sequences, and we can't tell which block is legit until we receive the finalization.
Closes #565