Skip to content

Preserve source changes made during watch reports - #122

Merged
ifuri-validator-agent[bot] merged 3 commits into
mainfrom
ticket/100-watch-report-race
Sep 10, 2026
Merged

ifuri-validator-agent[bot] merged 3 commits into
mainfrom
ticket/100-watch-report-race

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

A source edit made while a watch report finishes can disappear: the watcher replaces its whole baseline after generating the report. This caused the required CLI-watch test for #118 to time out.

Retain the pre-report source snapshot and exclude the declared report and cache outputs from scans. Preserve polling, throttling, cancellation and ignore rules. Source files adjacent to generated paths remain watched, including when outputDir is the repository root.

Validation: four deterministic cases failed before the fix. All 15 watcher/CLI cases now pass, including successful/failed reports, cache feedback and adjacent source paths. Full verify after integrating current main: 450 passed, zero failed, one optional Java skip. Governance has zero errors/warnings; offline and Docker smoke pass. Hosted Java 17 and independent exact-head Validator approval remain required.

Ticket: ticket-100. Disjoint dependency work for completing PLF-13849. No changes to test timeouts or publication gates.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 521a5de9f0d45fa21c8384693a6ea443d4606d42.

Ticket: ticket-100
Correlation ID: local-autogrammar-todo2code-pr-122-ticket-100
Model: openrouter/z-ai/glm-5.3-flash
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Watcher now retains the pre-report snapshot instead of rescanning after each report, and excludes pipeline-owned outputs (outputDir/runs, outputDir/latest.json, config.outputDir/cache) via an ignore matcher. The matcher correctly resolves to absolute paths and uses a path.sep-prefixed comparison, so siblings like runs-source.ts are not falsely ignored, including when outputDir is the repository root. Four deterministic regression tests cover successful/failed reports and both outputDir variants, and all required checks (verify, Java adapter JDK 17, koru / code-review) pass. Changes stay within intent.json's allowed paths.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: edb202d12d8ad91d1faa36479586b3a93037d484...521a5de9f0d45fa21c8384693a6ea443d4606d42
Change digest: 9c2fd5441f474881511fe6a3e10711a8971f2f1123a9dae4ad115d382c437111
Score: 60/100 (L), estimated 74 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":169,"base_sha":"edb202d12d8ad91d1faa36479586b3a93037d484","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"9c2fd5441f474881511fe6a3e10711a8971f2f1123a9dae4ad115d382c437111","comparison":"edb202d12d8ad91d1faa36479586b3a93037d484...521a5de9f0d45fa21c8384693a6ea443d4606d42","deletions":3,"file_count":4,"files":["project/ticket-100/README.md","project/ticket-100/intent.json","src/watch/watcher.ts","test/watch.test.ts"],"head_sha":"521a5de9f0d45fa21c8384693a6ea443d4606d42","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":3,"scope":3,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":74,"within_budget":false},"impact":{"components":["errors","project","src/watch","successful","test","watcher"],"files":["errors/warnings","project/ticket-100/README.md","project/ticket-100/intent.json","src/watch/watcher.ts","successful/failed","test/watch.test.ts","watcher/CLI"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":11,"name":"Implement errors","scope":["errors"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement src/watch","scope":["src/watch"]},{"estimated_minutes":11,"name":"Implement successful","scope":["successful"]},{"estimated_minutes":11,"name":"Implement test","scope":["test"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-100"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-100: Preserve source changes made during watch reports</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 105,51 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 74m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-100-9766
TICKET ticket-100
HEAD_SHA 521a5de9f0d45fa21c8384693a6ea443d4606d42
CORRELATION_ID local-autogrammar-todo2code-pr-122-ticket-100
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","Java adapter (JDK 17 required)=PASS","verify=PASS","koru / code-review=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"autogrammar/todo2code","pull_request":122,"head_sha":"521a5de9f0d45fa21c8384693a6ea443d4606d42","base_sha":"edb202d12d8ad91d1faa36479586b3a93037d484","diff_sha256":"bbde79ba9d9581cc92b4797bf1585e5f207461b21ecc8332c95e8802ae123374"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-100/README.md","project/ticket-100/intent.json","src/watch/watcher.ts","test/watch.test.ts"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"edb202d12d8ad91d1faa36479586b3a93037d484","head_sha":"521a5de9f0d45fa21c8384693a6ea443d4606d42","change_digest":"9c2fd5441f474881511fe6a3e10711a8971f2f1123a9dae4ad115d382c437111","score":60,"complexity":"L","estimated_minutes":74,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openrouter/z-ai/glm-5.3-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit cdf29f2 into main Sep 10, 2026
14 of 15 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/100-watch-report-race branch September 10, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant