Repository navigation
feat: add --schema and --data options for email and phone provider commands - #1705
Merged
ramya18101 merged 7 commits intoOct 19, 2026
Merged
Conversation
ramya18101
marked this pull request as ready for review
October 12, 2026 05:33
developerkunal
requested changes
Oct 13, 2026
developerkunal
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. The five commands follow the same pattern as the other groups, and build, unit tests, lint and the docs check all pass. I also ran every command live against a dev tenant, and --schema, --query and --data behaved as expected. There are two things to fix before this can merge, and one question. Details are in the inline comments.
ramya18101
deleted the
DXCDT-2372/agent-ergonomics-email-phone-providers
branch
October 19, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Extends the JSON-input / schema-discovery flag surface (already on
actions,roles,users,apis,apps,connections,logs,domains,email templates,universal-login, andacul config) to the email and phone provider commands, so agents and automation get the same whole-payload and schema-discovery interface. All flags reuse the existing shared helpers (internal/cli/schema.go,data_json.go,query_json.go); no new flag machinery was introduced.The flags
--schema: prints the OpenAPI request/query schema for the operation and exits (combine with--json/--json-compactfor machine-readable output).--data: whole-payload JSON for create/update: inline JSON,@file.json, or piped stdin; validated against the OpenAPI schema before the API is called.--query/-q: JSON object of query parameters for list commands.Per command
email provider create--data+--schema(POST/emails/provider)email provider update--data+--schema(PATCH/emails/provider)phone provider list--schema+--query(GET/branding/phone/providers)phone provider create--data+--schema(POST/branding/phone/providers)phone provider update--data+--schema(PATCH/branding/phone/providers/{id})Notable decisions
--datais mutually exclusive with every granular input flag viamarkDataExclusive, matching the other groups.--data,email provider updateandphone provider updateskip the pre-read and the interactive prompts and send the payload verbatim.--schemareturns before the provider ID is resolved, sophone provider update --schemaneeds no ID.📚 References
🔬 Testing
Manual smoke (against a tenant, non-mutating):
📝 Checklist
🤖 Generated with Claude Code