Accurately reflect return type for reflect() - #577
Merged
Conversation
filmaj
approved these changes
Sep 8, 2026
filmaj
left a comment
filmaj
left a comment
Member
There was a problem hiding this comment.
Thanks!
The funny thing is: this API never needed to return a promise. By the time the reflect method is defined, the tables are resolved. Ah well, not worth doing a breaking change or complicating this, I don't think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type definitions for the
reflect()method incorrectly defines it as a method that does not return a promise. As such, intellisense marks the await as being not necessary (see screenshot). This PR fixes that discrepancy.