Repository navigation
SmartPhoto を document への委譲で動かし、後から追加された要素にも反応させる - #74
Merged
Merged
Conversation
取得済みの要素を渡していたため、htmx や Ajax で差し込んだ要素には反応しなかった。 本体の組み込み JS と同じくセレクタを渡す。dispatch は複数回呼ばれるため、同じセレクタでは 1 回だけ生成する。 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容の概要
取得済みの要素（NodeList）を SmartPhoto に渡していたため、htmx や Ajax で後から差し込んだ要素には反応しなかった。本体の組み込み JS と同じくセレクタ文字列を渡し、
documentへの click 委譲で動かす。dispatchは複数回呼ばれるため、同じセレクタでは 1 回だけ生成する（生成のたびにdocumentへの委譲と<dialog>が増えるため）確認
documentへの click 委譲に対応していることをソースで確認vite build通過🤖 Generated with Claude Code