test(verify): run the source operators, and report what is covered - #8364
Open
kz930 wants to merge 2 commits into
Open
test(verify): run the source operators, and report what is covered#8364kz930 wants to merge 2 commits into
kz930 wants to merge 2 commits into
Conversation
A source reads a file rather than an upstream port, so it is configured from a file the runner writes rather than from a table, and the variants follow the configuration: a CSV with a header and without, an encoding per charset. Two reports come with it. One prints which operators run and which are withheld and why, so the state of the set is a command rather than a claim. The other parses every generated script and fails on one that a hostile column name would break, which is a whole class of defect a comparison cannot see. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
This was referenced Sep 2, 2026
…ady are It routes a source to the source runner and asks the escaping check for its findings, and the coverage report in turn reads the operators it discovered. Split across two changes those references point both ways, and neither compiles until both land whatever order they land in. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
A source reads a file rather than an upstream port, so it is configured from a
file the runner writes rather than from a table, and the variants follow the
configuration: a CSV with a header and without, an encoding per charset.
Two reports come with it. One prints which operators run and which are
withheld and why, so the state of the set is a command rather than a claim.
The other parses every generated script and fails on one that a hostile column
name would break, which is a whole class of defect a comparison cannot see.
Any related issues, documentation, discussions?
Part of #8325, 19 of 20; that issue lists the set in order.
How was this PR tested?
The tests in this change cover it. The whole set is exercised together once the last piece lands: every operator run through the engine and through its generated script, and the two answers compared.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)