Repository navigation
Conversation
Five external links in contributing.md (and the rendered site/contributing.html) currently return 200 only via redirect: - help.github.com (deprecated) to docs.github.com (2 occurrences) - oracle.com/technetwork (deprecated) to oracle.com/java/technologies (1) - http://legacy.python.org/dev/peps to https://peps.python.org (1) - http://docs.scala-lang.org to https://docs.scala-lang.org (1) Each is updated to its current canonical URL. Generated-by: Claude Opus 4.7 (1M context) (claude-opus-4-7)
nchammas
left a comment
There was a problem hiding this comment.
Thanks for updating these links. Could you check them again? It appears a couple of them still redirect to someplace else (perhaps due to the time that has passed since you initially submitted this PR).
Also, you don't need to submit changes to site/ anymore thanks to #699.
GitHub reorganized its docs again since this PR was opened, so the fork-a-repo and about-pull-requests URLs set here now 301-redirect. Point them at the current canonical paths.
Site HTML is generated and pushed automatically now (apache#699), so this PR should change contributing.md only.
|
Thanks @nchammas. Refreshed both GitHub links to the current canonical paths:
Verified both return 200 with no redirect. The other three (peps.python.org, oracle, docs.scala-lang.org) still resolve cleanly, so I left them. Also dropped the |
nchammas
left a comment
There was a problem hiding this comment.
LGTM pending a refresh of the PR description to reflect the current diff. I would also remove the actual before/after URLs from the description since they are already captured in the diff.
Five external links in
contributing.md(and the renderedsite/contributing.html) currently return 200 only via redirect to canonical destinations:https://help.github.com/articles/fork-a-repo/https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repohttps://help.github.com/articles/using-pull-requests/https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requestshttp://legacy.python.org/dev/peps/pep-0008/https://peps.python.org/pep-0008/http://www.oracle.com/technetwork/java/codeconvtoc-136057.htmlhttps://www.oracle.com/java/technologies/javase/codeconventions-contents.htmlhttp://docs.scala-lang.org/style/https://docs.scala-lang.org/style/GitHub deprecated
help.github.comin favor ofdocs.github.com, Oracle deprecatedtechnetwork, and the two HTTP URLs upgrade to HTTPS. The redirects work today but the canonical URLs are stable forever.The change touches both
contributing.mdandsite/contributing.htmlto keep the source and rendered files in sync, matching the convention from PR #679 (Fix a couple of typos in contributing.md).Generated-by: Claude Opus 4.7 (1M context) (claude-opus-4-7)