Serve Latest from the project, and build 0.5.0 documentation from docs/v0.5.0 - #938
Merged
Merged
Conversation
The numbered and the Latest documentation of 0.5.0 now build from the head of docs/v0.5.0 in apache/skywalking-ai-sessionizer, as 0.4.0's build from docs/v0.4.0. It is the v0.5.0 tag with documentation fixes only: the parts of #38 there that apply to 0.5.0, and what a set source_root means for claude-code-local.
✅ Deploy Preview for skywalking-website-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
A release carried latestLink and latestCommitId, so the Latest tree was
configured once per release and its pin was a second copy of the release
pin. They could drift, and in skywalking-go they had: Latest served
41a66149 while v0.7.0 served the tag.
The project now says where its two generated trees live:
docs:
link: /docs/skywalking-go/next/readme/
latest: /docs/skywalking-go/latest/readme/
Latest renders the commitId of the release marked latest, so a release
carries one pin and the two cannot disagree. The project-level next block
is gone; its keys moved to docs. skywalking-go v0.7.0 now pins 41a66149,
the documentation commit its Latest tree already served, so the numbered
tree gains the same fixes and no page changes.
The validator rejects the retired keys by name, and requires a commitId
on the latest release when the project serves Latest.
wu-sheng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to
data/projects.yml, the second one a schema change.AI Sessionizer 0.5.0 documentation. The numbered and the Latest documentation now build from the head of
docs/v0.5.0(532cc2de) instead of the v0.5.0 tag (8743b2cb), as 0.4.0's build fromdocs/v0.4.0. That branch is the tag with documentation fixes only: the parts of apache/skywalking-ai-sessionizer#38 that apply to 0.5.0, and what a setsource_rootmeans forclaude-code-local.Latest is configured on the project, and renders the latest release's own pin. A release carried
latestLinkandlatestCommitId, so the Latest tree was configured once per release and its pin was a second copy of the release pin. The project now says where its two generated trees live:Latest renders the
commitIdof the release markedlatest: true, so a release carries one pin and the two can never disagree. The project-levelnextblock is gone and its keys moved intodocs;data/get-started.ymlfollows for the Showcase. The validator now rejectslatestLinkandlatestCommitIdby name, and requires acommitIdon the latest release when the project serves Latest.One project's pins had drifted.
skywalking-goserved Latest from41a66149while v0.7.0 served the tagb52ef576. v0.7.0 now pins41a66149, the documentation commit Latest already served, so the numbered tree gains the same fixes and no published page changes.Checked:
node scripts/project-config.jsandnpm testpass (10 tests, updated for the new shape). The entriesderiveDocsListgenerates are byte-identical to master's apart from the three intended pins above — same 50 projects, same 81 documentation entries, same Latest URLs. A local Hugo build serves the same documentation links as the live site on /docs/ (65), /downloads/ (33), /get-started/ (2) and the home page (9).Follow-up, not in this PR:
tools/release/release.shin apache/skywalking-ai-sessionizer writeswebsite.txtwithlatestLinkandlatestCommitId, so it needs a matching update.