[spark] Close the commit and release the cached RDD in remove_unexisting_files - #9706
Open
cxzl25 wants to merge 1 commit into
Open
[spark] Close the commit and release the cached RDD in remove_unexisting_files#9706cxzl25 wants to merge 1 commit into
cxzl25 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
SparkRemoveUnexistingFilescreates aTableCommiton the executor insideforeachPartitionbut never closes it.TableCommitImpl.close()shuts down the underlying commit and themaintainExecutorthread pool, so every invocation of the procedure leaks a thread pool on a long-lived executor. Other call sites such asPaimonPartitionManagementalready wrap the commit in try/finally.The intermediate RDD is also cached and never unpersisted.
buildRDD()returned a child of the cached RDD to the caller, so the cache could only be released after the caller finished, which never happened. This change turns it intoexecute(), which collects the result inside the method and unpersists the cache in afinallyblock.Behaviour of the procedure is unchanged; only resource lifecycle is affected.
Tests