Repository navigation
Support append row kinds and historical row updates - #1180
Merged
Merged
Conversation
JingsongLi
force-pushed
the
codex/native-io-parity-audit
branch
from
October 20, 2026 03:01
e44ef2e to
ba5bf75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Close verified gaps in the existing PyPaimon Native write/update path, using current Java behavior.
rowkind.fieldon append and data-evolution tables, including CHAR/VARCHAR fields. Check required values before filtering; reject surviving DELETE/UPDATE_BEFORE events; honorignore-deleteandignore-update-beforebefore routing or materializing Blob inputs. Keep append files free of KV system fields.rowkind.fieldwith INPUT changelogs for primary-key tables and preserve the exact generated events. Resolve the event column once per batch and preserve its identity through reordered write types.write_cols.Ordinary write/commit entry points, upserts and MERGE clauses which can INSERT continue to reject historical handles. Publish historical update messages through a current table. No new public API or dependency.
Java references
AppendOnlyFileStoreTable.newWrite,TableWriteImpl.writeAndReturn,RowKindGenerator,RowKindFilter, andAppendOnlyWriter.write.MergeIntoPaimonDataEvolutionTable.withMatchedUpdateScanOptions, partial update write type, captured read snapshot and global-index update policy.Verification
-D warnings.cargo fmt --all -- --checkand diff checks.Companion Python PR: apache/paimon#10668 (draft). Its Native CI continues building Rust main and depends on this PR.
Review follow-up
_ROW_IDwithout borrowing the target view. Added committed-result and empty-source regressions.Follow-up verification: 64 related Rust integration tests passed; Core/Python binding all-target Clippy on Rust 1.98.0, fmt and diff checks passed. Independent review found no remaining actionable regression in the reviewed changes.