Repository navigation
[core] Align delete and update nullability with Java - #1179
Merged
JingsongLi merged 2 commits intoOct 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Align existing Python Native write/update behavior with current Java, preserving logical NOT NULL constraints while allowing valid deduplicate DELETE records and unused update inputs.
Companion Python PR: apache/paimon#10666.
Changes
PrimaryKeyFileStoreTable.store(). Preserve primary-key/sequence fields and the logical table schema.Verification
Review follow-up: real PyArrow-to-Core MERGE reproduces the old mixed-chunk schema failure, then passes with NULL chunks in either order, NULL ON keys, unmatched NULL payloads, and unused dictionary values that decode to NULL. Source schema/field metadata remains intact. Rust 1.98.0 binding all-target Clippy, rustfmt and diff checks pass.
New retained-delete integration suite: 3 passed. Covers explicit/configured row kinds, STRING/LargeString, automatic/precomputed buckets, separate INSERT and DELETE commits, sequence ordering, physical Parquet root fields, INPUT changelogs, value predicates that must not resurrect deleted rows, managed BLOB files, and required-field/other-engine/cross-partition negatives.
Existing filtered-write integration suite: 4 passed.
Python-binding Rust library: 104 passed. New source-transport and real upsert tests first fail on the old importer, then pass, including discarded duplicate values and invalid selected target NULLs.
Rust core library: 4319 passed, 7 ignored. Pinned Rust 1.98.0 core/binding all-target Clippy with
-D warnings, rustfmt and diff checks passed.Current Java reference tests
TableWriteTest.testDeduplicateDeleteWithPrimaryKeyOnlyandtestDeleteRequiresSequenceField: 2 passed.Companion Python regressions cover ordinary/dedicated-BLOB target constraints, physical schema flags, and real commit/read results. Local Python tests did not rebuild or install the Native extension.
No new dependency, public API, version probe or commit-failure cleanup is introduced.