Repository navigation
chore(databricks): remove the Python converter - #531
Merged
jbonofre merged 2 commits intoOct 8, 2026
Merged
Conversation
The Java converter under converters/databricks/java is the maintained implementation and covers the Python converter's behavior (apache#333, apache#496, apache#500), and the Python package was never published. Remove converters/databricks/python along with its CI job and Dependabot entry. The Cube interop matrix ran the databricks spoke through `uv run ossie-databricks`, which stopped resolving when the Python project moved under python/ in apache#333, so the spoke has reported SKIP since. Run the Java CLI's shaded jar instead, preferring $JAVA_HOME; the row reads SKIP when no Java 21+ JVM or no built jar is available. Label the CLI's notices so the warns/foreign columns still count them, and refresh the README's sample databricks row, which now includes the Java converter's dropped-`datatype` notices. Reword the docs and Java comments that pointed at the Python converter. Co-authored-by: Isaac <no-reply@databricks.com>
Keep this PR to the Python converter's removal: restore the Cube interop matrix and its README, which only consumed the Python CLI (its databricks spoke has reported SKIP since apache#333 moved the project under python/, so removal does not change it), and keep the docs and comment edits to the references the removal leaves dangling (the python/ links and "matching the Python converter" notes). Co-authored-by: Isaac <no-reply@databricks.com>
Member
|
@Haoranli503 it makes perfect sense for me. It could be confusing for users (which one they should use) especially when the two converters are not at the same level. If the Databricks guys are fine with that, I'm fine to merge. |
Contributor
Yes - consolidating around the Java impl LGTM. Thanks @Haoranli503 for the change - @jbonofre this looks good to merge |
jbonofre
approved these changes
Oct 8, 2026
Member
|
Thanks for confirming. Let's clean this up 😉 |
9 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated Python implementation of the Databricks converter. The Java converter under
converters/databricks/javabecomes the only implementation: it has been the maintained one since #333 and covers the Python converter's behavior (#496 ported the #428 cascade drop guards, #500 added the import tests the Java suite lacked). Theapache-ossie-databrickspackage was never published to PyPI.Changes:
converters/databricks/python(21 files), itspythonCI job, and its Dependabot entry. ThejavaCI job and the Maven Dependabot entry stay.python/row and link inconverters/databricks/README.md, the Python converter link and note inconverters/databricks/java/README.md, and Java comments that cited the Python converter or its tests. No Java code changes.Not changed: the Cube interop matrix (
converters/cube/tools/interop_matrix.py) still lists the databricks spoke asuv run ossie-databricks, which has reported SKIP since #333 moved the Python project underpython/. Pointing it at the Java converter is left to a separate change.Testing: the Java suite passes locally (89 tests). A few export edge case tests existed only in the Python suite and are not ported here.
Related Issues
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changes.github/labeler.ymlis updated with the new pathValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance
NOTICEand/orLICENSEhave been updated per ASF policy