Validator crashes instead of reporting errors for invalid YAML structures #270

Activity

1. mattfaltyn

   changed the title [-]Validator crashes on empty or non-mapping YAML roots[/-] [+]Validator crashes instead of reporting errors for invalid YAML structures[/+] on Jul 26, 2026
2. ihadoop commented on Oct 10, 2026

   

   ihadoop

   on Oct 10, 2026

   Contributor

   More actions

   Re-tested on current main (642cb89): this looks resolved, so noting the evidence for triage.

   All four inputs the issue names now exit 1 through the reporter, with no traceback:

   empty.yaml      -> [Schema] (root): None is not of type 'object'              exit 1
   sequence root   -> [Schema] (root): [] is not of type 'object'                exit 1
   scalar root     -> [Schema] (root): 'just a scalar' is not of type 'object'   exit 1
   

   The issue's own reproduction command behaves as it asked it should:

   $ python validation/validate.py /dev/null --schema core-spec/ossie-schema.json
   Validation FAILED with 1 error(s):
     [Schema] (root): None is not of type 'object'
   

   (the schema file has since been renamed from osi-schema.json)

   Against the proposed scope:

   • Report the schema errors already collected for structurally invalid documents — done. The AttributeError escape routes were closed by fix(validation): report unreadable input or schema, not a traceback #534 (unreadable input or schema) and fix(validation): reject a schema file that is valid JSON but not a schema #542 (a schema file that is valid JSON but not a schema).
   • Run semantic checks only after schema validation has established their expected nested shapes — already the case: in main() the unique-name, reference, arity and SQL checks sit behind if not errors and isinstance(data, dict) and 'datasets' in data, and the ontology checks behind 'ontology' in data.
   • Focused regression coverage for empty, sequence, scalar and malformed nested inputs — validation/tests (181 tests) and validation/test_validate.py (53 tests) both pass on main.

   Not my call to close it — reporting only that the reproduction no longer fails, in case this is stale.