Skip to content

VSNetBeans 31.0.1 preparation - #34

Merged
MartinBalin merged 1 commit into
apache:release3101from
MartinBalin:release3101
Sep 1, 2026
Merged

VSNetBeans 31.0.1 preparation#34
MartinBalin merged 1 commit into
apache:release3101from
MartinBalin:release3101

Conversation

@MartinBalin

Copy link
Copy Markdown
Contributor

NetBeans submodule to point to latest commit f8ac37e on NetBeans IDE release310 branch. .gitmodules updated on VSNetBeans release3101 branch as well.

@MartinBalin
MartinBalin requested review from sdedic and thurka August 31, 2026 14:43

@thurka thurka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MartinBalin
MartinBalin merged commit f98984b into apache:release3101 Sep 1, 2026
5 checks passed

@JaroslavTulach JaroslavTulach left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you really want to reference a "moving target" - e.g. a branch?

Comment thread .gitmodules
[submodule "netbeans"]
path = netbeans
url = https://github.com/apache/netbeans.git
branch = release310 No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • release310 is branch - e.g. it can move if someone commits to it.
  • wouldn't it be better to refer to a tag like 31
  • tags aren't supposed to move (unless one forces them)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not moving target. You need to see whole commit:

 git show 831e0822954c897073872225a32b0e90c4154592
commit 831e0822954c897073872225a32b0e90c4154592
Author: Martin Bal<C3><AD>n <Martin.Balin@oracle.com>
Date:   Mon Aug 31 16:40:25 2026 +0200

    netbeans submodule upd to release310

diff --git a/.gitmodules b/.gitmodules
index d40411a..8e9d99e 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,4 @@
 [submodule "netbeans"]
        path = netbeans
        url = https://github.com/apache/netbeans.git
+       branch = release310
\ No newline at end of file
diff --git a/netbeans b/netbeans
index 575f6fd..f8ac37e 160000
--- a/netbeans
+++ b/netbeans
@@ -1 +1 @@
-Subproject commit 575f6fd926c6b22f584347d3eba8ba86a4f3f48a
+Subproject commit f8ac37e0f2434a7f000fbe3360f1a92aa3ea67bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants