Conversation
Test Results 4 files 4 suites 44s ⏱️ Results for commit f84e0dd. ♻️ This comment has been updated with latest results. |
bonampak
reviewed
Sep 25, 2026
bonampak
left a comment
Contributor
There was a problem hiding this comment.
This looks ok, but logout.jsp should also be hardened.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3488 - harden original-url cookie validation
What changes were proposed in this pull request?
WebSSOResourcevalidated the redirect target only when it came from theoriginalUrlquery param — theoriginal-urlcookie branch used the value verbatim, skipping the userinfo and whitelist checks. A request carrying a crafted cookie was redirected to any attacker host, bypassing the configured (and default) whitelist.How was this patch tested?
Tested locally, new unit tests, homepage login