KNOX-3482: Expand Knox health endpoint integration coverage - #1426
Open
Raghav-Mah3shwari wants to merge 1 commit into
Open
Raghav-Mah3shwari wants to merge 1 commit into
Raghav-Mah3shwari wants to merge 1 commit into
Conversation
Test Results 4 files 4 suites 42s ⏱️ Results for commit 900f0e4. |
hanicz
requested changes
Sep 24, 2026
hanicz
left a comment
hanicz
left a comment
Contributor
There was a problem hiding this comment.
This file already have 4 different /ping tests that could be improved imo. I feel like they test the same thing just separately. I think they could be unified since these are not unit tests.
| msg="pretty metrics should include formatting whitespace", | ||
| ) | ||
| self.assertIn("\n", pretty.text) | ||
| self.assertEqual(json.loads(compact.text), json.loads(pretty.text)) |
Contributor
There was a problem hiding this comment.
I don't like this, this can easily fail in the future due to flakiness. You compare two different live metric snapshots.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added integration coverage for Knox health endpoints:
POST /gateway/health/v1/ping.?pretty=true.OKorPENDING).404.How was this patch tested?
The Maven build completed successfully.
The Docker Compose integration test suite was rebuilt and executed using:
mvn clean -Ppackage,release install -T 1C
-Dmaven.test.skip=true -Dpmd.skip=true -Dcpd.skip=true
-Dcheckstyle.skip=true -Dspotbugs.skip=true -Drat.skip=true
-Dforbiddenapis.skip=true -Denforcer.skip=true -Djacoco.skip=true
-Dmaven.javadoc.skip=true -Dmaven.source.skip=true
-Dshellcheck.skip=true -Dxml.skip=true
-s .github/workflows/build/settings.xml
docker compose -f ./.github/workflows/compose/docker-compose.yml
build --no-cache knox-dev
docker compose -f ./.github/workflows/compose/docker-compose.yml
down --remove-orphans
docker compose -f ./.github/workflows/compose/docker-compose.yml
up --exit-code-from tests tests
Results:
•Maven build: BUILD SUCCESS
•Integration tests: 106 passed, 0 failed
•Pylint: 10.00/10
Integration Tests
Updated .github/workflows/tests/test_health.py. The tests are automatically discovered and executed by the Docker Compose test job configured through .github/workflows/tests.
UI changes
No UI changes.