Repository navigation
chore: clean up audit ignores and cite LEGAL-732 in deny.toml - #3486
Open
kevinjqliu wants to merge 2 commits into
Open
kevinjqliu wants to merge 2 commits into
kevinjqliu wants to merge 2 commits into
Conversation
Cargo.lock now resolves quick-xml to 0.41.0, which contains the fix for RUSTSEC-2026-0194 and RUSTSEC-2026-0195. `cargo audit` passes without the ignores, so they no longer suppress anything. The rsa (RUSTSEC-2023-0071) and paste (RUSTSEC-2024-0436) ignores stay: both crates are still in Cargo.lock and `cargo audit` fails without them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
CDLA-Permissive-2.0 was allowed without a justification. ASF LEGAL-732 treats it as Category A, the same reference Apache OpenDAL cites in its deny.toml. Document it so reviewers can see why it is on the allowlist. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The lockfile supports removing the exceptions, and the license policy remains unchanged.
No open issues 🎉
What changed in this PR
Cleans up security-audit exceptions and documents an existing license allowance.
Changes:
- Removes two stale
quick-xmladvisory ignores. - Adds the ASF LEGAL-732 citation without changing the license allowlist.
| File | Description |
|---|---|
deny.toml |
Documents the existing CDLA-Permissive-2.0 allowance. |
.cargo/audit.toml |
Removes obsolete advisory exceptions. |
Review effort: Balanced
kevinjqliu
commented
Oct 17, 2026
| "ISC", | ||
| "CC0-1.0", | ||
| "Zlib", | ||
| # Category-A: https://issues.apache.org/jira/browse/LEGAL-732 |
Contributor
Author
There was a problem hiding this comment.
CDLA-Permissive-2.0 is not listed in https://www.apache.org/legal/resolved.html#category-a
so adding a comment here about why its Category-A
this is the only entry missing from the asf page
Comment on lines
-38
to
-39
| "RUSTSEC-2026-0194", | ||
| "RUSTSEC-2026-0195", |
Contributor
Author
There was a problem hiding this comment.
these are now stale and cargo audit --no-fetch still pass without them
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Drops stale
quick-xmladvisory ignores from.cargo/audit.tomland cites ASF LEGAL-732 forCDLA-Permissive-2.0indeny.toml.Are these changes tested?
Config-only.
cargo audit --no-fetchandcargo deny check licenseboth pass.AI Disclosure
Prepared with Copilot (cherry-picked existing commits and ran the checks); no areas of particular uncertainty.