Repository navigation
ci: Limit open, non-draft PRs to 3 for users without write access - #3465
Conversation
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
I think this is overall good for the health of the project, and we can always revert if its not.
Let's see what other folks think before merging
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
I'm +1 to this idea. Thanks Matt
Co-authored-by: Shawn Chang <yxchang@amazon.com>
| allow_auto_merge: true | ||
| # auto-delete head branches after being merged | ||
| del_branch_on_merge: true | ||
| # Limit open, non-draft PRs per user without write access. See CONTRIBUTING.md. |
There was a problem hiding this comment.
oh do they finally addressed that? I filed an initial issue for ASF INFRA to support this. need to check if it actually works
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich lets check if it works
laskoviymishka
left a comment
laskoviymishka
left a comment
There was a problem hiding this comment.
LGTM.
This is generally helpfull to focus efforts on review on what's really matter now instead of spreading thin
I think it'll also encourage non-committers to find other ways to contribute (e.g., review, foster community) beyond rapid-firing Claude-generated PRs. |
|
Thanks for this, I agree with the change. I had several PRs open while working on deletes and DVs, so I have converted some of them to drafts to stay within the limit, and will mark them ready again as the others land. Reviews on the open ones would be much appreciated whenever you have time. |
|
Thanks @mbutrovich for working on this! |
7 participants
Which issue does this PR close?
N/A.
What changes are included in this PR?
Enable
github.pull_requests.creation_capin.asf.yamlwithmax_open_pull_requests: 3, and document the limit inCONTRIBUTING.md. This follows apache/arrow-rs#11560 and apache/datafusion#25973, which adopted the same limit after the discussion in apache/datafusion#24413. ASF Infra added support for the setting in apache/infrastructure-asfyaml#111.Are these changes tested?
N/A.
AI Disclosure
Drafted with the help of Claude Code. The irony is not lost on me.