mod_systemd: Document Type=notify-reload, and test it - #729
Closed
notroj wants to merge 3 commits into
Closed
Conversation
ReloadSignal= and ExecReload=. Generated HTML not rebuilt. [skip ci] Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Type=notify-reload. * test/modules/arch/linux/env.py (TransientService): Take the service type and whether to configure ExecReload=. (TransientService.systemctl): Take a timeout. (TransientService.reload, TransientService.rewrite_conf, error_log_size, error_log_since, systemd_version): New. * test/modules/arch/linux/README: Describe the new suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
modules/arch/unix/, os/unix/, test/modules/arch/linux/ or to server/mpm_unix.c. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
notroj
force-pushed
the
systemd-notify-reload
branch
from
August 30, 2026 09:16
f5897c3 to
2e27e4f
Compare
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 30, 2026
ReloadSignal= and ExecReload=. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #729 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937646 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 30, 2026
Type=notify-reload. * test/modules/arch/linux/env.py (TransientService): Take the service type and whether to configure ExecReload=. (TransientService.systemctl): Take a timeout. (TransientService.reload, TransientService.rewrite_conf, error_log_size, error_log_since, systemd_version): New. * test/modules/arch/linux/README: Describe the new suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> GitHub: PR #729 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1937647 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents
Type=notify-reloadfor mod_systemd, wheresystemctl reloadwaits for the new configuration to be loaded and reports whether it worked, and adds a test suite covering it.The unit documented keeps
ExecReload=httpd -k gracefuland setsReloadSignal=SIGCONT. systemd runsExecReload=first and sendsReloadSignal=only once that has exited successfully, so keeping it is what makes an unparseable configuration fail the reload without the running server being signalled at all; with a bare reload signal the parent reads the new configuration itself and exits if it does not parse. The signal systemd sends afterwards is then redundant, and theSIGHUPdefault would restart httpd ungracefully.Also stops the Windows workflow running on Unix-only paths.