Repository navigation
Conversation
swuferhong
self-requested a review
September 18, 2026 05:00
swuferhong
reviewed
Sep 22, 2026
swuferhong
left a comment
swuferhong
left a comment
Contributor
There was a problem hiding this comment.
Hi, @fxbing. Such an useful metrics improvement. I left some comments:
Generate recursive raw error-code collection for protobuf messages. Count bucket failures without changing aggregate RPC error semantics. Cover response errors, message reuse, and encoding and metrics failures.
Register missing TabletServer APIs and split ListOffsets client/follower metrics. Exercise response errors with EmbeddedChannel tests and document the expanded metrics scope.
fxbing
force-pushed
the
feature/20260914-response-error-metrics
branch
from
September 23, 2026 02:20
c1982b8 to
efd8c79
Compare
swuferhong
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4359
Follow up on #4213 to count per-bucket errors returned inside normal RPC responses. These errors currently bypass
sendError()and are missing from the per-error metrics.Brief change log
NONE, while preserving the aggregate metric's whole-request failure semantics.Tests
API and Format
No public API, RPC wire-format, or storage-format changes. Per-error metrics now include bucket failures and therefore need not sum to the existing aggregate error metric.
Documentation
Updated the metrics reference to explain the counting semantics.
Generative AI disclosure