Repository navigation
[rust] Validate nested ROW field names - #4209
Merged
fresh-borzoni merged 3 commits intoSep 17, 2026
Merged
Conversation
Contributor
Author
|
@beryllw @fresh-borzoni, could you please take a look when you have a chance? Thanks! |
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@naivedogger Thank you for the PR, left minor comment, PTAL
Contributor
Author
|
@fresh-borzoni Thanks for catching this! I agree that blank top-level column names should also be rejected to keep consistent with the Java server. I’ve added the validation and tests. PTAL. |
fresh-borzoni
approved these changes
Sep 17, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@naivedogger Thank you, LGTM 👍
backport?
fresh-borzoni
pushed a commit
that referenced
this pull request
Sep 17, 2026
yangshangqing95
pushed a commit
to yangshangqing95/fluss
that referenced
this pull request
Sep 28, 2026
* [rust] Validate nested ROW field names * [rust] Centralize ROW field name validation * [rust] Reject blank table column names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4208
Brief change log
Tests
API and Format
Documentation