fix: honor custom converters registered for a type with an existing built-in converter on write - #1103
Open
roysti10 wants to merge 1 commit into
Open
fix: honor custom converters registered for a type with an existing built-in converter on write#1103roysti10 wants to merge 1 commit into
roysti10 wants to merge 1 commit into
Conversation
…uilt-in converter on write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #1102
What's changed?
Custom converters registered via
registerConverter()were silently ignored on write for any type with an existing built-in converter because they were stored under a different map key than the one the write-time lookup actually searches.Fixed
AbstractWriteHolderto also register custom converters under the key the lookup usesChecklist