Conversation
56wj
force-pushed
the
feat/instant-string-converter
branch
from
September 9, 2026 12:25
9077a24 to
87ce5b2
Compare
Author
|
CI on JDK 8/11 exposed a runtime compatibility difference: |
56wj
force-pushed
the
feat/instant-string-converter
branch
from
September 10, 2026 14:11
87ce5b2 to
3b7ae8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Related: #1017
Add JDK 8-compatible support for lossless conversion between
java.time.Instantand UTC ISO-8601 Excel string cells.What's changed?
InstantStringConverterusingOffsetDateTimefor UTC-only reads andInstant.toString()for canonical writes.Verification
mvn clean package -B -Dmaven.test.skip=false -pl fesod-common,fesod-shaded,fesod-sheetmvn -pl fesod-sheet -DskipTests spotless:checkResults after syncing current
mainon JDK 21: 924 tests, 0 failures, 0 errors, 0 skipped. The generated Surefire reports include 7 passingInstantStringConverterTestcases and 5 passingDefaultConverterLoaderTestcases.Checklist