Conversation
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
|
Done in 254a11e — renamed to |
|
It is recommended to add tests for the following scenarios to cover the complete behavior of
|
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
|
Added in faf2207, covering both layers:
Also adjusted the existing custom-format test: the previous Targeted tests 79/79, full fesod-sheet suite 933/933 green. |
|
|
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
|
Good catch @nkuprins — that was an oversight, fixed in 7986ca1: Without it, a Added a full round-trip regression ( |
Signed-off-by: BigDataDZ <76271875+BigDataDZ@users.noreply.github.com>
Purpose of the pull request
Implements two commonly used JDK 8 compatible converters requested by the community task #1017:
java.lang.Characterandjava.time.Year. Proposal comments:#1017 (comment) and the amendment below it
(
UUID/YearMonth/Instantwere proposed by other volunteers in parallel and are left tothem).
Related: #1017
What's changed?
CharacterStringConverter(org.apache.fesod.sheet.converters.charconverter): bidirectionalCharacter<-> STRING. Reading an empty string yieldsnull; strings longer than one characterthrow (wrapped into
ExcelDataConvertExceptionby the framework) instead of being silentlytruncated.
YearStringConverter(org.apache.fesod.sheet.converters.year): bidirectionalYear<->STRING, default format
uuuu, honors@DateTimeFormatcustom patterns andGlobalConfiguration.locale.Both follow the existing
*StringConverterpattern (e.g.LocalTimeStringConverter) and areregistered in
DefaultConverterLoaderunderputAllConverter,putWriteConverterandputWriteStringConverter, so they work on read, xlsx write and CSV write alike.Each converter ships with JUnit 5 unit tests (11 tests total: type keys, round-trips, default and
custom formats, and error cases).
Checklist