fix: use utf-8 for redirect pyproject generation - #925
Merged
Conversation
elijahbenizzy
approved these changes
Sep 10, 2026
elijahbenizzy
enabled auto-merge (squash)
September 10, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
burr-redirect/generate_pyproject.pyreads the template and writes the generated redirect packagepyproject.tomlwithout specifying a text encoding. On systems where the preferred locale is not UTF-8, that can make this release helper dependent on the local default encoding.Before / after
Before,
Path.read_text()andPath.write_text()used the platform default encoding.After, both template read and generated TOML write explicitly use UTF-8, matching the expected encoding for project metadata files.
Verification
python -m py_compile burr-redirect\generate_pyproject.pypython burr-redirect\generate_pyproject.py 0.43.0burr-redirect/pyproject.tomldid not change.