Skip to content

fix: use utf-8 for redirect pyproject generation - #925

Merged
elijahbenizzy merged 1 commit into
apache:mainfrom
Ghraven:fix-redirect-pyproject-utf8
Sep 10, 2026
Merged

fix: use utf-8 for redirect pyproject generation#925
elijahbenizzy merged 1 commit into
apache:mainfrom
Ghraven:fix-redirect-pyproject-utf8

Conversation

@Ghraven

@Ghraven Ghraven commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Problem

burr-redirect/generate_pyproject.py reads the template and writes the generated redirect package pyproject.toml without specifying a text encoding. On systems where the preferred locale is not UTF-8, that can make this release helper dependent on the local default encoding.

Before / after

Before, Path.read_text() and Path.write_text() used the platform default encoding.

After, both template read and generated TOML write explicitly use UTF-8, matching the expected encoding for project metadata files.

Verification

  • python -m py_compile burr-redirect\generate_pyproject.py
  • python burr-redirect\generate_pyproject.py 0.43.0
  • Confirmed the generated burr-redirect/pyproject.toml did not change.

@elijahbenizzy
elijahbenizzy enabled auto-merge (squash) September 10, 2026 22:12
@elijahbenizzy
elijahbenizzy merged commit 41e13d7 into apache:main Sep 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants