[Java] Move GCP-related secret classes and tests from sdks/java/core to google-cloud-platform-core - #40019
Open
shunping wants to merge 12 commits into
Open
[Java] Move GCP-related secret classes and tests from sdks/java/core to google-cloud-platform-core#40019shunping wants to merge 12 commits into
shunping wants to merge 12 commits into
Conversation
shunping
marked this pull request as ready for review
September 4, 2026 17:18
Collaborator
Author
|
r: @damccorm |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
reviewed
Sep 4, 2026
damccorm
left a comment
Contributor
There was a problem hiding this comment.
Please take a look at the precommit failure which looks related to the change:
1: Task failed with an exception.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
-----------
* What went wrong:
Execution failed for task ':sdks:java:core:analyzeClassesDependencies'.
> Dependency analysis found issues.
unusedDeclaredArtifacts
- com.google.protobuf:protobuf-java:4.33.6@jar
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org./
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':sdks:java:extensions:google-cloud-platform-core:analyzeClassesDependencies'.
> Dependency analysis found issues.
usedUndeclaredArtifacts
- com.google.protobuf:protobuf-java:4.33.6@jar
-
- ```
Contributor
|
Otherwise, this LGTM, thanks |
…XlangTest - Add TestSecretRegistrar in sdks/java/core/src/test for testing secret options - Update GroupByKeyWithGbekTest in ValidateRunnerXlangTest to use type:testsecret so cross-language tests run unconditionally without GCP Secret Manager
Collaborator
Author
|
Note that I also replace the use of GCP secret manager in XVR gbek test with a test secret manager so we won't have gcp deps in java/core. We already have integration tests for GBEK in |
shunping
force-pushed
the
secret-manager-5
branch
from
September 5, 2026 03:13
0a8c318 to
1224ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves Google Cloud Platform (GCP) secret manager implementations (
GcpSecret,GcpHsmGeneratedSecret) and theirSecretRegistrars (GcpSecretRegistrar,GcpHsmGeneratedSecretRegistrar) out ofsdks/java/coreintosdks/java/extensions/google-cloud-platform-core.This decouples
beam-sdks-java-corefrom GCP Secret Manager, Cloud KMS, and Tink dependencies, keepingcorelightweight while still supporting dynamic secret registration whengoogle-cloud-platform-coreis on the classpath viaServiceLoader.Notice that there is no functional change in this PR.
Follow-up to #39940 (comment)
Changes
GcpSecret,GcpHsmGeneratedSecret,GcpSecretRegistrar, andGcpHsmGeneratedSecretRegistrarfromorg.apache.beam.sdk.util(sdks/java/core) toorg.apache.beam.sdk.extensions.gcp.util(sdks/java/extensions/google-cloud-platform-core).SecretTestintoGcpSecretTestingoogle-cloud-platform-core.GcpSecretRegistrarTesttogoogle-cloud-platform-core.GroupByKeyandGroupByEncryptedKeyfromGroupByKeyTestandGroupByEncryptedKeyTestintoGcpGroupByEncryptedKeyTest.GroupByKeyITfromsdks/java/coretoGcpGroupByKeyITingoogle-cloud-platform-core.