feat(ingress-controller): support annotations on the webhook configuration - #1004
Open
ahmedgabers wants to merge 1 commit into
Open
ahmedgabers wants to merge 1 commit into
ahmedgabers wants to merge 1 commit into
Conversation
…ation The ValidatingWebhookConfiguration renders with no annotations, so external CA managers cannot be attached to it. With webhook.certificate.provided, operators supply a serving cert (commonly a cert-manager Certificate) but must hand-copy the CA into webhook.certificate.caBundle and re-copy it on rotation. An annotations knob lets cert-manager's cainjector own the caBundle instead (cert-manager.io/inject-ca-from), the standard pattern for webhook trust.
Author
|
Fixes #1006. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ValidatingWebhookConfiguration renders with no annotations, so external CA managers cannot attach to it. With
webhook.certificate.provided, operators supply a serving certificate (commonly a cert-manager Certificate) but must hand-copy the CA intowebhook.certificate.caBundleand re-copy it whenever it rotates.An
webhook.annotationsknob lets cert-manager's cainjector own the caBundle instead (cert-manager.io/inject-ca-from: <namespace>/<certificate>) — the standard pattern for webhook trust management.Verified with
helm template: the annotation renders onto the webhook configuration when set; unset output is byte-identical to today. Chart version bumped 1.3.0 -> 1.3.1; values doc comment and README row updated.