Repository navigation
fix: add required owner to marketplace.json so the plugin installs - #1
Merged
Merged
Conversation
`/plugin marketplace add aoc81/lore` has failed since the first commit:
Invalid schema: .claude-plugin/marketplace.json owner: Invalid input
`owner` is required by the marketplace schema and was never present, so the
plugin has never been installable from the marketplace — only loaded in-repo
as `lore@inline`, which skips that validation and hid the bug.
Add `owner`, and drop the root-level `displayName` that Claude Code ignores
at load time. `claude plugin validate .` now passes with no warnings, and
`marketplace add` + `install lore@lore` both succeed.
Guard it with tests/test_manifests.py: `owner`, no unknown root fields, each
entry's `source` resolves to a dir with a plugin.json, the three versions
agree, and every hooks.json command points at a script that ships.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
/plugin marketplace add aoc81/lorehas failed since the very first commit:owneris required by the marketplace schema and was never present in anyversion (checked back to v0.1.0). The plugin has only ever been loaded in-repo
as
lore@inline, which skips that validation — which is why this wentunnoticed through five releases.
The fix
ownerto.claude-plugin/marketplace.json.displayName, which Claude Code ignores at load time(
claude plugin validatewarns about it). The per-entry one stays.Verification
claude plugin validate .passes with no warnings, and end-to-end in anunrelated repo:
All 9 skills and 5 hooks load; ~246 tokens always-on.
Regression guard
New
tests/test_manifests.py(stdlib, picked up by the existing CIunittest discover): assertsowneris present and named, no unknownroot-level fields, each entry's
sourceresolves to a directory containing aplugin.json, the three declared versions agree, and everyhooks.jsoncommand points at a script that actually ships. Confirmed it fails if
owneris removed again. Full suite: 159 tests, OK.
No version bump — since the marketplace was never addable, nobody has 0.5.0
installed through it.