fix(requester-node-http): remove listeners after request settles - #1612
Closed
Steve0x2a wants to merge 1 commit into
Closed
fix(requester-node-http): remove listeners after request settles#1612Steve0x2a wants to merge 1 commit into
Steve0x2a wants to merge 1 commit into
Conversation
Signed-off-by: Yi Zhan <stevesough@gmail.com>
|
Thanks for contributing to our API clients! Sorry to close your PR, but this repository is fully generated, you can port your changes to the API Clients Automation repository. If you need some guidance, feel free to open an issue or read our contribution guide. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 14 |
| Duplication | 2 |
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createHttpRequesterattacheddata/end/errorlisteners on each Nodehttpresponse (anderroron the request) and never tore them down. With the keep-alive agent those emitters stay reachable, so the handlers keep response buffers alive across repeatedclient.search()calls.On success, error, and timeout, this now calls
removeAllListeners()on the request and response so those handlers cannot retain the settled exchange.Thanks @aymeric-giraudet for the report and the
removeAllListenersworkaround.Fixes #1570