Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle a rejected async transform handler in the same
thencall as its fulfillment. Attachingcatchto the original promise leaves the promise returned bythenunhandled, so a process can terminate even after the callback or pipeline has received the error.Adds callback and pipeline regressions in child processes with
--unhandled-rejections=strict; both fail before the fix and pass afterward. The original error is preserved.Validation: stream-transform's 79 tests and type checks pass on Node 20, 22 and 24; package lint and build pass. Full workspace
npm testpasses on Node 24 (1,047 passing, 6 existing pending). Root lint still reports 5 errors and 6 warnings in unchanged packages, identical to an unmodified-source run.