Repository navigation
Conversation
This will avoid the need to call lseek(2) after writing the temporary JSON file. Rename xwrite() to xpwrite0(), to indicate the use of pwrite(2) with an initial 0-offset. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
No need to lseek after xpwrite0(). Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
🟢 Approval recommended
The offset behavior is preserved correctly across both updated call sites.
0 open findings
What changed in this PR
Replaces sequential temporary-file writes with positioned writes while preserving read offsets.
Changes:
- Renames
xwritetoxpwrite0. - Uses
pwritefrom offset zero and removes redundant initial seeks. - Updates related error messages.
| File | Description |
|---|---|
src/itsa.c |
Adds positioned full-write handling for generated JSON files. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.