Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Uninitialized request data, misleading quit behavior, swallowed failures, and temporary-file leaks must be fixed.
2 open findings
What changed in this PR
Adds accounting-adjustment submission after triggering a Business Source Adjustable Summary.
Changes:
- Prompts users to submit adjustments or a zero-adjustment request.
- Validates the returned calculation ID.
- Displays submission responses.
| File | Description |
|---|---|
src/itsa.c |
Implements accounting-adjustment submission workflows. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
After triggering a business source adjustment summary, you should then submit an accounting adjustment if any or submit a zero adjustments request. The user is now prompted about the above after triggering a BSAS and the accounting adjustments are now submitted. This re-works trigger_bsas() to not allow the editing of the JSON being submitted as there is no need to. The only thing to change is the start and end date and that is either calculated automatically or specified by the user when calling this function. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After triggering a business source adjustment summary, you should then submit an accounting adjustment if any or submit a zero adjustments request.
The user is now prompted about the above after triggering a BSAS and the accounting adjustments are now submitted.