Pick up human generated plans from issues (#22) - #24
Merged
ableinc merged 1 commit intoSep 6, 2026
Conversation
Closes #22 Generated by coding-agent-loop run f85a9b37-859f-4072-9888-d233640c1afc.
ableinc
marked this pull request as ready for review
September 6, 2026 10:50
ableinc
deleted the
agent/issue-22-pick-up-human-generated-plans-from-issue
branch
September 6, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
What the agent did
This matches the approved plan exactly. Everything builds, vets, and tests pass (aside from pre-existing, unrelated
internal/gittest failures caused by the sandbox's git environment, confirmed present before my changes too).Summary
Implemented issue #22 exactly per the approved plan:
internal/config/config.go: addedGitHubConfig.HumanPlannedLabel(json:"human_planned_label"), defaulting to"human-planned".config.example.json,README.md: documented the new field (config table, config example, and the plan-lifecycle step).internal/orchestrator/report.go: addedhumanPlanComment(plan, runID string), structurally identical toplanComment(same marker/header/footer, soextractPlantreats it identically) but without the model/cost line, and noting the plan came from a human.internal/orchestrator/loop.go: inexecute(), short-circuits to a newadoptHumanPlanmethod wheneverphase == phasePlanand the issue carriesHumanPlannedLabel.adoptHumanPlantrimsissue.Body, errors loudly on an empty body, posts/saves the plan, swapsWorkingLabel→PlanLabel, setsStatusPlanned, logs an event, and notifies Discord (PlanPostedwith a nil*claude.Result, which it already tolerates). No clone, worktree, or Claude run is triggered.TestDefaultHumanPlannedLabel(config),TestHumanPlanCommentRoundTripsThroughExtractPlan(report), and two integration tests in the existinginternal/orchestrator/adopt_test.go(which already held the shared fixtures the plan called out) — one confirming the plan is adopted/posted/saved with nopr create, one confirming an empty body fails loudly viaagent-failedwith nothing saved.One deviation worth flagging: the plan called for a new file
internal/orchestrator/adopt_test.go, but that file already existed in the repo with the exact fixtures described (testOrchestrator,stubGH,openTestStore), so I added the two new tests there instead of creating a duplicate file.Verification
Tests failed (
make test). This PR is a draft — the failure is reported rather than hidden, so you can judge whether the change is salvageable.Test output (tail)
Changes
Opened automatically by coding-agent-loop (run
f85a9b37-859f-4072-9888-d233640c1afc, attempt 2, modelclaude-sonnet-5, cost $1.5602, session1e49ca54-6127-4ffa-9b6d-00806df8d826). Nothing here has been reviewed by a human yet.