fix: harden production network and dependency boundaries - #20
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved SSRF bypasses, response buffering, repository validation, and lockfile issues remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 4
Open (6)
What changed in this PR
Hardens production network requests and dependency boundaries by adding SSRF protections, response-size limits, repository validation, and removing a duplicate Vite dependency.
Changes:
- Adds DNS/IP and redirect safeguards for URL inspection.
- Bounds remote response sizes.
- Tightens GitHub repository identifiers.
- Removes the duplicate Vite plugin dependency.
| File | Summary |
|---|---|
server.ts |
Adds SSRF checks, response limits, and repository validation. |
package.json |
Removes the duplicate Vite plugin dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+652
to
+654
| return a === 10 || a === 127 || (a === 169 && b === 254) | ||
| || (a === 172 && b >= 16 && b <= 31) | ||
| || (a === 192 && b === 168); |
Comment on lines
+650
to
+663
| if (net.isIPv4(address)) { | ||
| const [a, b] = address.split('.').map(Number); | ||
| return a === 10 || a === 127 || (a === 169 && b === 254) | ||
| || (a === 172 && b >= 16 && b <= 31) | ||
| || (a === 192 && b === 168); | ||
| } | ||
| if (net.isIPv6(address)) { | ||
| return normalized === '::1' | ||
| || normalized.startsWith('fc') | ||
| || normalized.startsWith('fd') | ||
| || normalized.startsWith('fe8') | ||
| || normalized.startsWith('fe9') | ||
| || normalized.startsWith('fea') | ||
| || normalized.startsWith('feb'); |
Comment on lines
+669
to
+672
| const resolved = await dns.lookup(hostname, { all: true }); | ||
| if (resolved.length === 0 || resolved.some((entry) => isPrivateAddress(entry.address))) { | ||
| return res.status(400).json({ error: 'Private or local network targets are not allowed.' }); | ||
| } |
Comment on lines
+669
to
+672
| const resolved = await dns.lookup(hostname, { all: true }); | ||
| if (resolved.length === 0 || resolved.some((entry) => isPrivateAddress(entry.address))) { | ||
| return res.status(400).json({ error: 'Private or local network targets are not allowed.' }); | ||
| } |
| @@ -15,7 +15,6 @@ | |||
| "dependencies": { | |||
| "@google/genai": "^2.4.0", | |||
| "@tailwindcss/vite": "^4.1.14", | |||
Comment on lines
711
to
+713
| const htmlText = await response.text(); | ||
| if (Buffer.byteLength(htmlText, 'utf8') > 2 * 1024 * 1024) { | ||
| return res.status(413).json({ success: false, url, httpStatus, latencyMs, contentType, verdict: 'unreachable', error: 'Response body too large.' }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate Vite plugin dependency, block private-network SSRF targets in live URL inspection, constrain GitHub repository identifiers, and bound remote HTML response sizes.