Repository navigation
feat: link to our X account in the webapp and mobile app - #269
Merged
Merged
Conversation
abarghoud
changed the title
…d xl In French, the X button pushed the language switcher onto a second line from 1024 to 1279 px, and the FAQ bar already wrapped there on main. Between lg and xl, GitHub and X show their logo only, spacing is tighter and the logo is smaller; nothing changes from xl up or in the mobile menu.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds links to our X account, @sentryguardorg, in the webapp and the mobile app.
Webapp
LayoutandPublicLayout.enandfr.Mobile
EXPO_PUBLIC_DISCORD_URL.openXAccount()andX_ACCOUNT_URLinsettings.helpers.ts, with a unit test.at(SF Symbol, Ionicons fallback on Android and web), since neither icon set has the X logo.enandfr.Testing
nx run-many -t lint,test,typecheck -p webapp mobilepasses (webapp 220, mobile 320, 0 lint errors).